Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX build #9

Open
emillon opened this issue Oct 19, 2016 · 4 comments
Open

Fix OSX build #9

emillon opened this issue Oct 19, 2016 · 4 comments

Comments

@emillon
Copy link
Contributor

emillon commented Oct 19, 2016

At the moment the build fails on osx.

Make it possible to either:

  • not build the reverse bindings (the only part that fails)
  • build the reverse bindings on osx.

The current solution (disable the whole package on osx) also works. To anyone interested: patches welcome :)

@vbgl
Copy link

vbgl commented Mar 30, 2017

The dlfcn.h header is available on osx. It seems enough (at least, it fixes the build) to generalize the #if defined(__linux__) || (defined(__sun) && defined(__SVR4)) conditional to include defined(__APPLE__).

@emillon
Copy link
Contributor Author

emillon commented Mar 30, 2017

Hi,

Great, I don't have an OSX system so I did not know what was the macro to use.

If you submit a pull request making sure that it builds and the tests pass, I'll include that in the next release.

Thanks!

@yallop
Copy link
Contributor

yallop commented Mar 30, 2017

It could be useful to add an OS X entry to the Travis configuration to ensure that the build keeps working.

@emillon
Copy link
Contributor Author

emillon commented Mar 30, 2017

@yallop IIRC OSX support for Travis makes really long builds, I don't think it's worth having it permanently enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants