Install latest fuzzer #46
Conversation
|
WalkthroughThis pull request introduces updates to the dependencies in Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (6)
- .shellcheckrc (1)
- cmd/cloudexec/cancel.go (1)
- cmd/cloudexec/main.go (1)
- flake.nix (3)
- justfile (1)
- packer/provision.sh (3)
Files ignored due to filter (1)
- flake.lock
Files skipped from review due to trivial changes (1)
- cmd/cloudexec/cancel.go
Review comments generated (10)
- Review: 8
- LGTM: 2
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| ######################################## | ||
| ## Helper Functions | ||
|
|
||
| function github_api { | ||
| project="$1" | ||
| github_api="https://api.github.com/repos/${project}/releases/latest" | ||
| curl -s "${github_api}" | ||
| } | ||
|
|
||
| function get_latest_version { | ||
| github_api "$1" | jq '.tag_name' | tr -d 'v' | tr -d '"' | ||
| } | ||
|
|
||
| function get_latest_artifact { | ||
| github_api "$1" | jq '.assets[] | select(.name | test("linux")) | .browser_download_url' | tr -d '"' | ||
| } | ||
|
|
There was a problem hiding this comment.
The helper functions github_api, get_latest_version, and get_latest_artifact are well implemented. They use the GitHub API to fetch the latest version of a given project and the URL for the latest artifact for a Linux system. However, there is no error handling in case the GitHub API request fails or returns an unexpected response. Consider adding some error checking to these functions.
function github_api {
project="$1"
github_api="https://api.github.com/repos/${project}/releases/latest"
response=$(curl -s "${github_api}")
if [ $? -ne 0 ]; then
echo "Failed to fetch data from GitHub API for project ${project}"
exit 1
fi
echo "${response}"
}
Query github to determine the most recently released version of echidna, medusa, and doctl. Then install that version.
Removes the need to periodically update packer/provision.sh to update to the latest version. Instead, we can just re-run the packer command.
Summary by CodeRabbit
cancel.goandmain.gofor better code readability.flake.nixandpacker/provision.sh. Removed thegocodepackage from native build inputs.doctl,echidna, andmedusainpacker/provision.shto always fetch and install the latest versions, reducing the need for manual updates.justfilerequire further review.