Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does this repo relate to node-cs3apis? #4

Closed
michielbdejong opened this issue Aug 11, 2021 · 5 comments
Closed

How does this repo relate to node-cs3apis? #4

michielbdejong opened this issue Aug 11, 2021 · 5 comments

Comments

@michielbdejong
Copy link

Can someone explain the difference between https://github.com/cs3org/js-cs3apis and https://github.com/cs3org/node-cs3apis? Would be good to link these two repos from their readme's.

@ptsefton
Copy link

Any progress on this?

@michielbdejong
Copy link
Author

Yes, I think the difference is that node-cs3apis includes a grpc client, and js-cs3apis does not.

See cs3org/node-cs3apis#6 (comment)

But also see cs3org/node-cs3apis#8
and cs3org/node-cs3apis#10 about move from "just JavaScript support" to "JavaScript as well as TypeScript support".

Seeing also @marcolarosa 's experience in cs3org/reva#2169
maybe we should just remove one of the two repos.

@labkode any preference of whether we keep 'js-cs3apis' or 'node-cs3apis'?
Now that people often generate client-side javascript from npm modules anyway, it probably no longer makes sense to have a separate 'node-' one, we can just have 'js-cs3apis' that includes the grpc client for node and the typings for TypeScript?

@marcolarosa
Copy link

marcolarosa commented Nov 1, 2021

@michielbdejong Out of curiosity, why is the grpc client included in the node repo and not in the js repo? Does that explain #5?

@michielbdejong
Copy link
Author

@marcolarosa I don't know the reasons, that was before my time. I'm now using my add-typings branch for
the reva client in the ocm test suite, hth!

@michielbdejong
Copy link
Author

Ah, actually I found https://github.com/grpc/grpc-web which seems related to how this repo works.
So it's probably worth keeping it around. But I'll improve the readme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants