Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repetitive Dataset and DataLoader Creation in PyTorch version #96

Open
sptom opened this issue Jul 4, 2022 · 0 comments
Open

Repetitive Dataset and DataLoader Creation in PyTorch version #96

sptom opened this issue Jul 4, 2022 · 0 comments

Comments

@sptom
Copy link

sptom commented Jul 4, 2022

Hi there!
My question is - is there any particular reason for creating the entire dataset and dataloader every epoch from scratch? This is done in the PyTorch version, in the main_train file:

image

As I see it - it doesn't add anything because the addition of the noise is done in the 'get_item' function, so the noise is randomized any way a batch is drawn anyway. So this creation takes time from computing the same dataloader each epoch, without adding value.

Am I missing something? Please correct me if I'm wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant