Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level_number missing from level_completed events in FTM #936

Closed
burrage opened this issue Dec 21, 2023 · 4 comments
Closed

level_number missing from level_completed events in FTM #936

burrage opened this issue Dec 21, 2023 · 4 comments
Assignees
Labels
bug Something isn't working High Priority

Comments

@burrage
Copy link
Contributor

burrage commented Dec 21, 2023

Describe the bug
From v1.0.20 onward, the level_number key-value pair is not reported in the level_completed Firebase event.

To Reproduce
Steps to reproduce the behavior:

  1. In BigQuery, for day-based query of level_completed events:

SELECT *
FROM ftm-b9d99.analytics_159643920.events_20231219
WHERE event_name = 'level_completed'

OR (for scale-- all of December)
SELECT *
FROM ftm-b9d99.analytics_159643920.events_202312*,
UNNEST (event_params) as event_params
WHERE event_name = 'level_completed' AND event_params.key = 'level_number'

Expected behavior
A level_number key-value pair should be reported with each level_completed event.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

@burrage burrage added bug Something isn't working High Priority labels Dec 21, 2023
@jeffoberlander
Copy link
Collaborator

I also noted that app_id is not coming into any of the events. Might be a separate issue to work on, but just noting this for when you are in the code.

@jeffoberlander jeffoberlander pinned this issue Dec 21, 2023
Rajesh1041 added a commit that referenced this issue Dec 22, 2023
#936 fixes level_number missing from level_completed events in FTM
@jeffoberlander
Copy link
Collaborator

Thank you @ashishkrr ! Related question: Can there be a "level_completed" event that has a level_number of 0? Right now in the DB there are several of these. Wondering if its pre-bug fix. Or if its legitimate. After "first_open" what will be the first event written ? Would it be a "puzzle_completed" event?

@jeffoberlander
Copy link
Collaborator

Actually. I just checked the DB and we are still getting "level_completed" events with no level_number

@burrage
Copy link
Contributor Author

burrage commented Jan 3, 2024

@jeffoberlander Circling back to the app_info values not being present on level_completed, etc. events comment-- oooo! I know why that is and it may be a bigger item to solve!

So... There are two instances of Firebase collecting data here:

1.) At the Curious Reader Android app level.
2.) At the individual app level (FTM, interactive book, assessment).

When we collect data from FTM, since it is grabbing data at the more granular web-app level, technically, that Firebase instance (2) doesn't know that FTM is being played within an Android app so it wouldn't automatically have the app_info data inserted.

Whereas events that are at the Curious Reader Android app level DO have app_info filled out automatically because it knows it is an Android app.

This probably brings up the question, "Why have two instances of Firebase collecting data like this?" I think it just came after the fact-- FTM JS came first and had Firebase at that level and when the Curious Reader container app came, we didn't have a way to capture those higher level Android events (what app is someone launching? etc.) so we put Firebase into that too.

That may not be the right path moving forward but it did also allow flexibility of collecting usage of the apps on the web and not solely within the Curious Reader app like if we ever just had people that wanted to play FTM on a computer or iOS device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority
Projects
None yet
Development

No branches or pull requests

4 participants