From 578995a97c0cbcecdee0d936e38ba7eb4e633dc4 Mon Sep 17 00:00:00 2001
From: Ivan Kovmir <ivan.kovmir@cybertec.at>
Date: Tue, 14 Mar 2023 12:03:52 +0100
Subject: [PATCH] Add shmem check in SQL function to avoid segmentation fault

---
 pg_show_plans.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/pg_show_plans.c b/pg_show_plans.c
index 4917126..7bfd90f 100644
--- a/pg_show_plans.c
+++ b/pg_show_plans.c
@@ -88,6 +88,8 @@ static void cleanup(int code, Datum arg);
 static void set_state(const bool state);
 /* Set query plan output format: text, json, ... */
 static void set_format(const int format);
+/* Check the extension has been properly loaded. */
+static inline void shmem_safety_check(void);
 /* Check whether the user has required privileges. */
 static bool is_allowed_role(void);
 /* Hook functions. */
@@ -324,6 +326,7 @@ void cleanup(int code, Datum arg)
 void
 set_state(const bool state)
 {
+	shmem_safety_check();
 	if (is_allowed_role())
 		pgsp->is_enabled = state;
 }
@@ -331,10 +334,23 @@ set_state(const bool state)
 void
 set_format(const int format)
 {
+	shmem_safety_check();
 	if (is_allowed_role())
 		pgsp->plan_format = format;
 }
 
+inline void
+shmem_safety_check(void)
+{
+	if (pgsp && pgsp_hash)
+		return;
+
+	ereport(ERROR,
+	        (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+	         errmsg("pg_show_plans must be loaded"
+	                "via shared_preload_libraries")));
+}
+
 bool
 is_allowed_role(void)
 {
@@ -520,6 +536,8 @@ pg_show_plans(PG_FUNCTION_ARGS)
 	int              curr_nest;
 	bool             is_done;
 
+	shmem_safety_check();
+
 	if (SRF_IS_FIRSTCALL())
 	{
 		MemoryContext oldcontext;