Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the problem of pinyin ambiguity #4

Open
d33tah opened this issue Jul 22, 2018 · 1 comment
Open

Solve the problem of pinyin ambiguity #4

d33tah opened this issue Jul 22, 2018 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed UX This is related to user experience

Comments

@d33tah
Copy link
Owner

d33tah commented Jul 22, 2018

As an example, enter 吧巴八 in "Characters" field. Note that in review phase, you will be asked to write "bā“ twice even though the application means two different characters. A simple improvement would IMHO be to add radical in those cases - we already have it in dictionary.txt, so it's a matter of detecting this case and adding it.

@d33tah d33tah added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers UX This is related to user experience labels Jul 22, 2018
@d33tah d33tah removed the good first issue Good for newcomers label Jul 30, 2018
d33tah added a commit that referenced this issue Jul 30, 2018
This is not perfect yet. Compare 作 and 做. Might need to add stroke
count.
@d33tah
Copy link
Owner Author

d33tah commented Jul 30, 2018

I pushed the solution, but it appears it's only partial, which is why I decided to remove "good first issue" tag - apparently it's not trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed UX This is related to user experience
Projects
None yet
Development

No branches or pull requests

1 participant