Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the Clone in Main Profile #108

Open
TheRealMystic opened this issue Jul 28, 2022 · 5 comments
Open

Mark the Clone in Main Profile #108

TheRealMystic opened this issue Jul 28, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@TheRealMystic
Copy link
Collaborator

TheRealMystic commented Jul 28, 2022

Currently, we still haven't found a way to identify the managed user profile (work profile or which multi-user profile) where an app or clone is installed.

However, we CAN identify whether the clone is installed in the Main Profile.

In cases where clones are present in Multiple profiles, it helps to see details of which profile a clone is installed in (such as User 0, 10, 11, 12, etc.).

Since clones in the main profile can be currently identified, can you include the same as follows:

iMarkup_20220728_100323

Once we figure out how to identify other profiles, the same can be implemented for clones in other profiles too.

@TheRealMystic TheRealMystic added the enhancement New feature or request label Jul 28, 2022
@d4rken d4rken added this to the Next Tasks milestone Jul 28, 2022
@d4rken
Copy link
Member

d4rken commented Jul 28, 2022

I can get the ID for the the primary profile, and the work profile, but for extra user profiles, I can't, I'm just guessing.

@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 28, 2022

That's already promising.

@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 31, 2022

I can get the ID for the the primary profile, and the work profile, but for extra user profiles, I can't, I'm just guessing.

PP sees an app installed in a multi-user profile, even though it can't get its icon.

Since you can get the ID for apps in the primary profile as well as work profile, an app whose ID cannot be obtained can be marked as one in a multi-user profile.

You can also assign a badge, which should be different from the one used for Work profile, to make them distinguishable.

We can remove 'Apps in Managed Profile(s)' and add two new Filters:

  1. Apps in Work Profile
  2. Apps in Multi-User

@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 31, 2022

Likewise, the permissions statement for such apps would read as follows:

For apps in Work Profile:

This app is installed in Work Profile. Permissions granted can be determined only for apps installed in the currently Active Profile, due to Android Restrictions.

For apps in Multi-User Profile:

This app is installed in a Multi-User Profile. Permissions granted can be determined only for apps installed in the currently Active Profile, due to Android Restrictions.

@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Aug 1, 2022

The reason for re-wording these is to let the user know that he can still view the permissions by installing Permission Pilot in those profiles.

The previous wording was not making this very obvious. It could potentially have been (mis)interpreted to mean that the status for those apps could not be determined at all, which is not true.

The new wording is much more clearer, and tells the user implicitly to install PP in other profiles too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants