Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support argocd.argoproj.io/manifest-generate-paths #57

Open
gozer opened this issue Nov 4, 2024 · 1 comment
Open

Support argocd.argoproj.io/manifest-generate-paths #57

gozer opened this issue Nov 4, 2024 · 1 comment
Labels
enhancement New feature or request feature-request Feature Request good first issue Good for newcomers

Comments

@gozer
Copy link

gozer commented Nov 4, 2024

ArgoCD already has an annotation argocd.argoproj.io/manifest-generate-paths. similar to argocd-diff-preview/watch-pattern

It would be very handy if argocd-diff-preview supported using it as well as the existing argocd-diff-preview/watch-pattern for detecting changes in monorepos

@dag-andersen dag-andersen added the enhancement New feature or request label Nov 4, 2024
@dag-andersen
Copy link
Owner

Hi @gozer,

Yes, you’re absolutely right! This feature has been requested in other forums too, and it's a good point.

Supporting manifest-generate-paths is a bit more complex than the current watch-pattern. This approach would require parsing each source's path and appending the manifest-generate-paths dynamically — but it’s definitely feasible!

If anyone is interested in giving it a shot, I believe it could be implemented by modifying this function. I'll plan to work on this myself eventually, but contributions are always welcome!

@dag-andersen dag-andersen added good first issue Good for newcomers feature-request Feature Request labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request Feature Request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants