Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery and Inverter CAN does not display correctly what makes the launch algorithm impossible for OFF grid system #758

Closed
GoSmartEV opened this issue Jan 6, 2025 · 1 comment

Comments

@GoSmartEV
Copy link

GoSmartEV commented Jan 6, 2025

I’ve discovered an issue, and it turns out it’s been around for a long time. It exists in all the versions I know.
Here’s the situation: the MCP2515 is installed, and when the system starts, the checkmark shows that there is a connection with the inverter but not with the battery. However, this is not actually true. You can tell because the battery has provided all valid values, but the inverter is disconnected since it’s power off because it get power from the battery.

Using a CAN analyzer, I see that packets intended for the battery are flying over the MCP2515.

There’s an issue in the code regarding the allocation of where the battery data and inverter data should go, which makes it impossible to start the battery.

In the latest fix that Dala made, a 60-second delay was added to allow the inverter to establish a connection before the battery can be started and the inverter turned on.
#751

Maybe someone can help identify the issue?

By the way, I forgot to mention that there are no "events" errors, just information about a reboot.

Battery checkmark true, Invertor checkmark feil

Actual Behavior

Battery checkmark feil, Invertor checkmark true

Steps to Reproduce the Problem

Don't conect CAN invertor to the lilygo and start it

Settings

add mcp2515
#define CAN_ADDON
battery = CAN_ADDON_MCP2515, // Which CAN is your battery connected to?
inverter = CAN_NATIVE, // Which CAN is your inverter connected to? (No need to configure incase you use RS485)

  • Software version: Doesn't matter``
  • Battery used: Doesn't matter``
  • Inverter communication protocol: BYD CAN``
  • Hardware used for Battery-Emulator: HW_LILYGO
  • CONTACTOR_CONTROL: Doesn't matter
  • CAN_ADDON: yes
  • WEBSERVER: yes

1111

@GoSmartEV
Copy link
Author

user.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant