Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle_focus_layout to core commands? #763

Open
urob opened this issue Jan 9, 2024 · 0 comments
Open

Add toggle_focus_layout to core commands? #763

urob opened this issue Jan 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@urob
Copy link
Contributor

urob commented Jan 9, 2024

As a follow-up to #759, do we want to add a toggle_focus_layout command to core? This wouldn't be a priority as one can easily implement it in the csx with something like this:

    context.CommandManager.Add(
            identifier: "toggle_focus_layout",
            title: "Toggle focus layout",
            callback: () =>
            {
                IWorkspace workspace = context.WorkspaceManager.ActiveWorkspace;
                if (workspace.ActiveLayoutEngine.Name == "Focus")
                {
                    workspace.LastActiveLayoutEngine();
                }
                else
                {
                    workspace.SetLayoutEngineFromName("Focus");
                }
            }
    );

On the other hand, this seems like something others might want to use and might be worth having in the API?

@urob urob added the enhancement New feature or request label Jan 9, 2024
@urob urob changed the title Add toggle_focus_engine to core commands? Add toggle_focus_layout to core commands? Jan 9, 2024
@dalyIsaac dalyIsaac moved this to Triage in Whim Jan 10, 2024
@dalyIsaac dalyIsaac removed the status in Whim Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant