Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize "Pending" zarr if all upload URLs must have timed out by now #2051

Open
yarikoptic opened this issue Oct 17, 2024 · 3 comments
Open
Labels
zarr Issues with Zarr hosting/processing/etc.

Comments

@yarikoptic
Copy link
Member

yarikoptic commented Oct 17, 2024

Instigator:

which summarizes as - we do not adjust "modified" time stamp of the dandiset even if zarr is modified (some files uploaded/changed) whenever it is never finalized. I think we should have some periodic job which would go through Pending zarrs, and if it was put into Pending state longer before the time window we allow for uploads/changes to happen in zarr -- "forcefully" finalize it in current state

NB in principle, whenever we have versioning implemented, we could revert back by removing versions of modifications to the keys and DeleteMarkers possibly added. But since we do not track to that level ATM, we cannot revert AFAIK. Also reversal might introduce the need to add similar reversal in backups2datalad (or just to not update Zarr until finalized into specific version), thus the easiest is just to finalize.

I think it might relate to

@jjnesbitt
Copy link
Member

Another way to go about this is to send recurring emails to dandiset owners if zarrs/blobs have been lingering in an unfinished state. This would encourage them to take action on those stale files.

@satra
Copy link
Member

satra commented Nov 4, 2024

@jjnesbitt - i think this is where the ui thought process may have come, and it came up in the context of unembargoing blobs. we perhaps need something to finalize or cancel blobs or zarrs on the ui side in addition to reminders. i don't know if the user has any option to cancel an unfinished upload now or to find it.

@yarikoptic
Copy link
Member Author

yarikoptic commented Dec 20, 2024

instead of finalizing it we might want to actually "roll back" (delete uploaded since prior finalized state versions and deletemarkers)... something to keep in mind for redesign (#1892)

edit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zarr Issues with Zarr hosting/processing/etc.
Projects
None yet
Development

No branches or pull requests

3 participants