Add option to disable / change language of spell check

[tomaskavalek]

After last update – so I am using version 3.4.1.

Please, allow to disable spellcheck in the app. I am writing a lot of messages in czech language, so every word is with red line below, and every next word slowing down the message box. Allow to choose the language or disabling this spellcheck.

Thanks a lot.

[tomaskavalek]

Probably this piece of code.

[jklp]

Added a new preferences pane to Goofy v3.4.2 - where I've given the option for the user to disable the spell checker.

I've also added a drop down to select between the two different types of english or use the system locale (might work in some instances?). Will expand to include more languages in future but hopefully the system one should work for now.

[jklp]

Ugh that's frustrating ... seems to work on my local machine though changing languages on the github binary doesn't seem to work (disabling spell check does work though)

Re-opening so we can look at in next milestone

[tomaskavalek]

I have downloaded version 3.4.2 and everything works as I expected.

If I enable spell checker and keep select as System, so app use English spell-checker on my Czech locale. But it's due to missing support from spell-checker – English only.

[tomaskavalek]

If I uncheck spell checker, it's disabled. Good work I think.

[jklp]

Yeah sorry - was hoping would be a little cleaner but got too excited with the preferences pane I didn’t 100% let it bake before releasing.

More than happy to accept PRs / feedback and now with preferences pane hopefully in good shape to make Goofy a little more configurable.

[jklp]

Now using electron-spellchecker to do spell checking which seems a lot more reliable.

[tomaskavalek]

Still not working. See electron-userland/electron-spellchecker#120. Have you tested it?

[jklp]

Yep, am located in Australia so I use UK English vs US and spelling errors have been highlighting correctly for me

Unfortunately I don't speak any other languages but I did do some quick testing with French and German via Google Translate which seemed to work - is it not working for you?

By the way you'll need to restart Goofy for the language change to work (I haven't put in hot reloading of any settings yet)

[jklp]

Have confirmed, looks like problem upstream with electron-spellchecker - other issues below:

electron-userland/electron-spellchecker#85
electron-userland/electron-spellchecker#61

Have set spell checking to disabled by default as I don't think should remove entire feature if some users will find it helpful - have added doc to let users know the feature isn't 100% working though so hopefully clears things up.

Haven't closed issue but moved out of 3.4.3 - lets revisit when we get some answers from electron-spellchecker (or find another lib which does the job)

[Palivec]

Hi ! I have a similar problem here !

My system language is English, but I write lot of Czech text too. Altough the spell check is disabled in Goofy preferences window, the app still checks the spelling, and only in English ! That means that all the Czech text is marked as incorrect, and it can't be disabled.

Moreover, changing Goofy spell option several times led to a blank app window and I had to delete all its ~/Library files. The option doesn't work for me at all.

I use Goofy 3.4.3 and MacOS 10.14.4

[jklp]

@Palivec Hi did you restart Goofy after disabling Spell check in preferences? I just tried disabling on my end and typing in some Czech and no spelling errors are highlighted.

[jklp]

Looks like Electron supports spell checking natively now!

electron-userland/electron-spellchecker#85 (comment)

[jklp]

Just double checked, only supported in Electron 8 (still in beta) - will look into again once Electron 8 is out