Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /to tooling links for pub redirects #6279

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

parlough
Copy link
Member

In an effort to standardize on /to for tooling redirects.

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Dec 16, 2024

Visit the preview URL for this PR (updated for commit cabc912):

https://dart-dev--pr6279-fix-pub-redirects-to-links-rkbywktu.web.app

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between /to and /go links? If they're no different should the goal be to move everything to the more common /go? If there is a meaningful difference, carry on!

@parlough
Copy link
Member Author

What's the difference between /to and /go links? If they're no different should the goal be to move everything to the more common /go? If there is a meaningful difference, carry on!

Due to historical reasons and clarity, /go for Flutter redirects is reserved for design docs. So we started using /to for tooling redirects. I wrote https://github.com/flutter/flutter/blob/master/docs/contributing/use-reliable-links.md with some guidelines on when to add and use a /to link for Flutter contributors

For consistency purposes, I felt it would be best to adjust links from tools to use /to/ on dart.dev as well. Then we could repurpose /go for whatever we want/need (perhaps design docs as well or temporary redirects).

Do you think it's worth making that transition? Or unnecessary for dart.dev?

@parlough parlough merged commit d996801 into main Dec 18, 2024
10 checks passed
@parlough parlough deleted the fix/pub-redirects-to-links branch December 18, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants