Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Unused Deps #896

Closed
AurevoirXavier opened this issue Jun 2, 2022 · 8 comments
Closed

Clean Unused Deps #896

AurevoirXavier opened this issue Jun 2, 2022 · 8 comments

Comments

@AurevoirXavier
Copy link
Member

Use frame_support::log instead log if we have frame_support already.

@ECJ222
Copy link
Contributor

ECJ222 commented Sep 26, 2022

Hey @AurevoirXavier,

If I understand your issue correctly, you are saying the frame_support pallet should be replaced with log instead wherever it is referenced.

@AurevoirXavier
Copy link
Member Author

Hey @AurevoirXavier,

If I understand your issue correctly, you are saying the frame_support pallet should be replaced with log instead wherever it is referenced.

That's a part of this issue.


Also checks cargo-udeps.

@ECJ222
Copy link
Contributor

ECJ222 commented Oct 6, 2022

After performing checks, There was a small issue with the syn crate not being updated to the current version.

The sp-core-hashing-proc-macro dependency on darwinia is referencing an older version of the syn crate which requires the parse_quote_spanned macro which at 1.0.81 has not yet been created.

@AurevoirXavier
Copy link
Member Author

After performing checks, There was a small issue with the syn crate not being updated to the current version.

The sp-core-hashing-proc-macro dependency on darwinia is referencing an older version of the syn crate which requires the parse_quote_spanned macro which at 1.0.81 has not yet been created.

cargo update -p syn --precise 1.0.96

@ECJ222
Copy link
Contributor

ECJ222 commented Oct 15, 2022

running udeps doesn't work, it's conflicting with the build scripts metadata.

There's an issue already open for error: #97 #256

@ECJ222
Copy link
Contributor

ECJ222 commented Oct 15, 2022

I found an alternative that works cargo-machete, What do you think?

@AurevoirXavier
Copy link
Member Author

Could you open a PR? I'll check the detail.

@ECJ222
Copy link
Contributor

ECJ222 commented Oct 23, 2022

Yeah sure @AurevoirXavier, I just did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants