Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp11 branch make install is broken #77

Open
rianquinn opened this issue Apr 11, 2017 · 7 comments
Open

cpp11 branch make install is broken #77

rianquinn opened this issue Apr 11, 2017 · 7 comments

Comments

@rianquinn
Copy link

rianquinn commented Apr 11, 2017

Make install does not install any of the needed headers.

/home/user/bfprefix/include/hippomocks.h:100:28: fatal error: detail/replace.h: No such file or directory
#include "detail/replace.h"
@rianquinn
Copy link
Author

This is what I think the install code for CMake should look like

install(FILES ${PROJECT_SOURCE_DIR}/HippoMocks/hippomocks.h DESTINATION include)
install(FILES ${PROJECT_SOURCE_DIR}/HippoMocks/comsupport.h DESTINATION include)
install(DIRECTORY ${PROJECT_SOURCE_DIR}/HippoMocks/detail DESTINATION include)

@dascandy
Copy link
Owner

It needs the opposite fix actually; it should be available as a single header file again.

@rianquinn
Copy link
Author

@dascandy one way to fix that if your trying to keep things clean would be to use CMake Install to merge the files for you. I'm pretty sure CMake can do that

@rzr
Copy link
Contributor

rzr commented Jan 31, 2018

Yes I can check this for next release

@rianquinn
Copy link
Author

Any status on this?

@rzr
Copy link
Contributor

rzr commented Feb 16, 2018

yes cmake has install feature

What is the plan for next release ? should it only support cmake or both ?

Related:
#86

@dascandy
Copy link
Owner

dascandy commented Mar 1, 2018

@rianquinn I might as well fix this issue while watching your CppCon talk. I had no idea you were there presenting it.

dascandy pushed a commit that referenced this issue Mar 1, 2018
dascandy pushed a commit that referenced this issue Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants