Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Paginate to view all Folders #288

Closed
noah-paige opened this issue Jan 31, 2023 · 2 comments · Fixed by #1158
Closed

Can't Paginate to view all Folders #288

noah-paige opened this issue Jan 31, 2023 · 2 comments · Fixed by #1158
Labels
priority: low status: not-picked-yet At the moment we have not picked this item. Anyone can pick it up type: bug Something isn't working
Milestone

Comments

@noah-paige
Copy link
Contributor

Describe the bug

If I have 11 or more Folders in one Data All dataset I am not able to see more than the first 10 and can not click to the next page to view any additional

This occurs when looking at the Folders Table in the Data Tab view when clicking on a specific data.all dataset (additional - I can search for the additional folders by name and they appear but can not click to retrieve the next page)

How to Reproduce

*P.S. Please do not attach files as it's considered a security risk. Add code snippets directly in the message body as much as possible.*
  1. Create a dataset in data all and add 11 or more folders
  2. scroll to the Folders Table under the Data tab of the dataset --> attempt retrieve the next page of folders information

Expected behavior

No response

Your project

No response

Screenshots

No response

OS

n/a

Python version

n/a

AWS data.all version

v1.3.1

Additional context

No response

@noah-paige noah-paige added the type: bug Something isn't working label Jan 31, 2023
@dlpzx dlpzx self-assigned this Feb 1, 2023
@dlpzx dlpzx added the status: in-progress This issue has been picked and is being implemented label Feb 1, 2023
@dlpzx dlpzx added status: not-picked-yet At the moment we have not picked this item. Anyone can pick it up and removed status: in-progress This issue has been picked and is being implemented labels Jun 5, 2023
@dlpzx dlpzx removed their assignment Jun 5, 2023
@anmolsgandhi
Copy link
Contributor

Hi @noah-paige is this issue this applicable in v2.2+? i see the version mentioned is v1.3.1.

@dlpzx dlpzx added this to the v2.3.1 milestone Mar 12, 2024
dlpzx added a commit that referenced this issue Apr 9, 2024
### Feature or Bugfix
- Bugfix

### Detail
Missing `pages` introduced a bug in the Datasets-> Data Tab - > Folder
table pagination. This PR fixes the bug #288

### Relates
- #288

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@noah-paige noah-paige linked a pull request Apr 10, 2024 that will close this issue
@noah-paige
Copy link
Contributor Author

Closing as complete in #1158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low status: not-picked-yet At the moment we have not picked this item. Anyone can pick it up type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants