Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test utils should also use spreadsheet notation #10

Open
filipsch opened this issue Sep 11, 2018 · 0 comments
Open

Test utils should also use spreadsheet notation #10

filipsch opened this issue Sep 11, 2018 · 0 comments

Comments

@filipsch
Copy link
Contributor

The tests make heavy use of utility classes such as Mutation, Deletion etc to mutate the student and solution data and then verify these variations against SCTs. If the operations are specific to a range, this range is specifed as a row and column index. However, there are utils in sheetwhat that neatly transform e.g. "A1" into (0,0).

The proposal is to have classes such as Mutation and Deletion also take in the more human-readable 'range specification', making use of the translation utility behind the scenes, so tests become easier to read and reason about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant