Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Timezone handling across elements #63

Closed
CBroz1 opened this issue Mar 15, 2022 · 1 comment
Closed

Timezone handling across elements #63

CBroz1 opened this issue Mar 15, 2022 · 1 comment
Labels
enhancement New feature or request standardization To be implemented across all elements
Milestone

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented Mar 15, 2022

NWB exports require time information as UTC with timezone offset as ISO 8601 extended formatted strings (docs and original discussion).

Our current approach in the elements is to ask the user to provide datetime information in UTC and assume local time zone when importing. This introduces inaccuracies if the local offset has changed since time of recording (e.g., daylight savings), or the user performing the export is in a different location from data collection. Modalities will differ in how they record metadata, so we may also encounter issues combining our session UTC with modality-specific recording start times.

I propose (a) adding timezone offset to session.Session and (b) treating modality-specific timestamps as encoded with this offset. This will permit analyses within DataJoint to consider local time, but will require NWB export functions to remove the offset from all modality-specific tables.

@CBroz1 CBroz1 added the enhancement New feature or request label Mar 15, 2022
@CBroz1 CBroz1 added this to the NIH U24 Year 3 milestone May 4, 2022
@CBroz1 CBroz1 added the standardization To be implemented across all elements label May 5, 2022
@CBroz1 CBroz1 removed this from the 2022Q1 milestone May 6, 2022
@kabilar kabilar added this to the 2023Q2+ milestone May 9, 2022
@kabilar kabilar modified the milestones: 2023Q2+, 2022Q3 Jul 15, 2022
@kabilar
Copy link
Collaborator

kabilar commented Oct 11, 2022

Manually moved to datajoint/element-interface#57

@kabilar kabilar closed this as completed Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request standardization To be implemented across all elements
Projects
None yet
Development

No branches or pull requests

2 participants