Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno Support #157

Open
vorcigernix opened this issue Aug 7, 2022 · 4 comments
Open

Add Deno Support #157

vorcigernix opened this issue Aug 7, 2022 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@vorcigernix
Copy link

I tried to use the project in Deno. The automated skypack module does not work, so I tried to copypaste the source to my project, but I wasn't able to get it running due to dependencies (sometimes circular). My hope is that the browser module would work just fine once you build it (I played with microbundle branch as well). If not, would you consider investing your time to make this module deno compatible?

@dawsbot
Copy link
Owner

dawsbot commented Aug 7, 2022

Hi @vorcigernix, I'm open to considering this. Can you make a minimal repo which includes essential-eth to show this error? I will pull that repo down and work with that to try and solve the issue

@vorcigernix
Copy link
Author

vorcigernix commented Aug 8, 2022 via email

@vorcigernix
Copy link
Author

vorcigernix commented Aug 8, 2022

So here is the repo that actually partly works: https://github.com/vorcigernix/essential-eth-deno
The biggest problem for me is that sometimes I don't know what the helper functions do, I believe that we will be able to write some of them more elegantly. Edit: I mean, thanks to deno, not my skills :D
Also, there is a very simple way to stay node compatible (in deno->node direction), so the node users can benefit from this as well (I am using node in like 90% of my projects).

@dawsbot dawsbot changed the title Deno Add Deno Support Aug 8, 2022
@dawsbot
Copy link
Owner

dawsbot commented Aug 8, 2022

@vorcigernix I added this to the official roadmap.

Since you are the first to request this, it is low-priority for now. If you have an interest in fixing this, please PR the repo 🙏

@dawsbot dawsbot added bug Something isn't working help wanted Extra attention is needed labels Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants