You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to make a test for testing the helpers like: prepareTransaction buildRPCPostBody toChecksumAddress cleanLog
Lmk what other helpers need to be tested @dawsbot
The text was updated successfully, but these errors were encountered:
Great idea, feel free to make a PR for this whenever @jtfirek . It will be good to be confident our helpers are doing what we think so that one break to helper shows up in the tests right there instead of downstream and we only notice it in a different function!
The way we are using the helper functions in the new mocked test will not catch bugs introduced in helper functions like
prepareTransaction
.essential-eth/src/providers/test/json-rpc-provider/call.test.ts
Lines 81 to 86 in 69cec04
We need to make a test for testing the helpers like:
prepareTransaction
buildRPCPostBody
toChecksumAddress
cleanLog
Lmk what other helpers need to be tested @dawsbot
The text was updated successfully, but these errors were encountered: