Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check-box styling is overridden by browser instead of bootstrap #306

Closed
hipitihop opened this issue Sep 20, 2021 · 2 comments
Closed

Check-box styling is overridden by browser instead of bootstrap #306

hipitihop opened this issue Sep 20, 2021 · 2 comments
Assignees
@MawiraIke
Labels
styling wontfix

Comments

@hipitihop
Copy link
Contributor

Check-box styling is overridden by browser instead of bootstrap:

Chrome:
image

FireFox:
image

Notice it not only affects the primary color, but also the disabled look.
Although we now support :parts this should probably use bootstrap defaults?
@MawiraIke
Copy link
Contributor

After some checking, it seems like Bootstrap v3(which re-com uses) and Bootstrap v4 have no default colour for checkboxes. The default colour seems to have been added in Bootstrap v5. Adding support for this would mean hardcoding the styling. I would prefer this to wait for component restyling to be completed first since it will override the styling.

@hipitihop
Copy link
Contributor Author

@MawiraIke I agree. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MawiraIke MawiraIke

Labels
styling wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@superstructor @hipitihop @MawiraIke