-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Description from schema.yml is not used for materialized view for BigQuery. #1374
Comments
@KevinCharette have you enabled persist_docs and I wanted to make sure, does this work in an schema.yml file (not on the model config?) |
👋 @amychen1776,
I'm confused about this question
What do you mean exactly? If you are asking wether we can add the description in the schema.yml, no it does not work (this is the base of the issue). |
@KevinCharette In order to apply the description from your configuration to the warehouse, you need to have persist_docs set to True. Have you done this in your project? Your example shows the description in a model configuration but not on an YAML file so I wanted to make sure. You can apply descriptions on a project.yml, model config block, and an property file (which is a yml file) |
Yes. It is done in our
Got it. |
Thank you for the confirmation! This appears to be a bug then and we will scope it out for timing |
Is this a new bug in dbt-bigquery?
Current Behavior
The description field in the
schema.yml
is not used to update the table description in BigQuery. The description of the table in BigQuery is left to empty.Interestingly, adding the description in the sql model is working.
Expected Behavior
The table description in the
schema.yml
should be pushed to and updated in BigQuerySteps To Reproduce
materialized='materialized_view'
as option.schema.yml
with a descriptiondbt run -s your_model
Relevant log output
No response
Environment
Additional Context
Quick investigation:
It looks like the issue is coming from here
The
description
coming from theschema.yml
is underrelation_config.description
but the code is usingrelation_config.config.extra.get(option)
When I inspect
relation_config.config.extra
I only see the description field that is provided in the SQL model file using something like this:The text was updated successfully, but these errors were encountered: