Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure we have complete regex coverage #454

Closed
dave-connors-3 opened this issue May 23, 2024 · 2 comments
Closed

ensure we have complete regex coverage #454

dave-connors-3 opened this issue May 23, 2024 · 2 comments
Assignees
@graciegoheen @dave-connors-3
Milestone
v1.0.0

Comments

@dave-connors-3
Copy link
Collaborator 

          wouldn't this change this to "at least 1 word character followed by 0 or 1 dash followed by at least 1 word character?)

Originally posted by @graciegoheen in #451 (comment)
@dave-connors-3
Copy link
Collaborator Author

add tests as well!

@dave-connors-3
Copy link
Collaborator Author

update the regex that allows for dash characters to ensure single character database/schema/identifier names are still valid

@dave-connors-3 dave-connors-3 added this to the v1.0.0 milestone Oct 24, 2024
@dave-connors-3 dave-connors-3 self-assigned this Oct 24, 2024
@dave-connors-3 dave-connors-3 mentioned this issue Oct 25, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graciegoheen graciegoheen

@dave-connors-3 dave-connors-3

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@graciegoheen @dave-connors-3