Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Allow generic tests to accept arbitrary configs #6274

Closed
FishtownBuildBot opened this issue Oct 10, 2024 · 0 comments · Fixed by #6312
Closed

[Core] Allow generic tests to accept arbitrary configs #6274

FishtownBuildBot opened this issue Oct 10, 2024 · 0 comments · Fixed by #6312
Assignees
@dbeatty10
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Oct 10, 2024 •
edited by dbeatty10
Loading

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.
Originating from this issue: dbt-labs/dbt-core#10484
PR: dbt-labs/dbt-core#10767

We needed to implement this feature twice to get it right. See #5679 for the original docs PR that we can probably largely or completely copy.
@FishtownBuildBot FishtownBuildBot mentioned this issue Oct 10, 2024
Closed
2 tasks
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Oct 10, 2024
@dbeatty10 dbeatty10 mentioned this issue Oct 17, 2024
Closed
@dbeatty10 dbeatty10 changed the title [Core] Docs Changes Needed from dbt-core Issue #10484 [Core] Allow generic tests to accept arbitrary configs Oct 17, 2024
@dbeatty10 dbeatty10 mentioned this issue Oct 17, 2024
Merged
1 task
runleonarun added a commit that referenced this issue Nov 14, 2024
@dbeatty10 @runleonarun @mirnawong1
Generic data tests accept arbitrary configs (#6312)
c90f8fb 
## What are you changing in this pull request and why?

Closes #6274

## Checklist
- [x] I have reviewed the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.

<!-- vercel-deployment-preview -->
---
🚀 Deployment available! Here are the direct links to the updated files:


-
https://docs-getdbt-com-git-dbeatty-docs-issue-5548-dbt-labs.vercel.app/reference/data-test-configs

<!-- end-vercel-deployment-preview -->

---------

Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Mirna Wong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbeatty10 dbeatty10

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generic data tests accept arbitrary configs dbt-labs/docs.getdbt.com
3 participants
@runleonarun @dbeatty10 @FishtownBuildBot