Update Trilinos configuration for complex & float. #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Feb 20, 2024
| @@ -263,9 +263,7 @@ CONFOPTS="\ | |||
|
|
|||
| if [ ${TRILINOS_WITH_COMPLEX} = ON ]; then | |||
| CONFOPTS="\ | |||
| -D Trilinos_ENABLE_COMPLEX_DOUBLE=ON \ | |||
There was a problem hiding this comment.
They are set to ON dependent on ENABLE_COMPLEX and ENABLE_FLOAT. See also https://www.docs.trilinos.org/files/TrilinosBuildReference.html#enabling-float-and-complex-scalar-types
Long story short: Packages do not use these configuration options consistently in Trilinos, or they apply different logic on how to configure based on these options. Since ENABLE_COMPLEX and ENABLE_FLOAT also set ENABLE_COMPLEX_DOUBLE and ENABLE_COMPLEX_FLOAT, I believe it is more robust to go with the first set of options.
|
How do we proceed here? |
tjhei
approved these changes
May 16, 2024
|
Sorry, thank you for digging into this issue. I will merge and then we will see if any problems come up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to trilinos/Trilinos#12750.
See also: https://www.docs.trilinos.org/files/TrilinosBuildReference.html#enabling-float-and-complex-scalar-types
I moved the
ENABLE_FLOAToption to the full configuration of Trilinos, as opposed to just for Teuchos. Is there a reason you only enabled it for Teuchos?