Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay Protection enable / disable in GUI #36

Open
andiohn opened this issue Oct 3, 2024 · 4 comments
Open

Overlay Protection enable / disable in GUI #36

andiohn opened this issue Oct 3, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andiohn
Copy link

andiohn commented Oct 3, 2024

This might be a great idea. Perhaps even v1 of this improvement could be to just read the state. "Overlay Protection is turned on, please disable before making changes"

Or, better yet, find a way to only persist changes for Piosk settings...somehow. :)

@andiohn
Copy link
Author

andiohn commented Oct 3, 2024

OOOOhhhhh. Good idea here. What if we could specify the websites to use and maybe some other small settings on our github? That way it could just read that on boot up, if it exists, it uses those! If it's not set, then show the default!

That would be a big step to make this really reliable.

@andiohn
Copy link
Author

andiohn commented Oct 3, 2024

Making that comment a separate issue.

@debloper
Copy link
Owner

debloper commented Oct 7, 2024

Or, better yet, find a way to only persist changes for Piosk settings...somehow.

Not sure if selective overlay is a thing. I would adopt it, if possible (would prefer to limit writes on the card, but current method doesn't allow that).

Open the issue back again when more details is available.

@debloper
Copy link
Owner

debloper commented Oct 8, 2024

As discussed in #37 this may be part of a dashboard feature as a toggle that would require a reboot to apply.

@debloper debloper reopened this Oct 8, 2024
@debloper debloper added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed wontfix This will not be worked on labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants