Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to force an audio flush before sending the Finalize command. #358

Open
QuinnDamerell opened this issue Dec 28, 2024 · 0 comments
Open

Comments

@QuinnDamerell
Copy link

What is the current behavior?

There's no way to flush the audio buffer in the send channel. The Finalize command uses the Send Immendaty function, which could allow the Finalize command to be sent before the buffered audio is sent.

Steps to reproduce

Use the Send function to send audio. Use the SendFinalize.

Expected behavior

There are a few fixes:

  1. Make the SendFinalize async block until the send queue is empty (doesn't seem ideal)
  2. Add a flush function that allows the client to async block until the send queue is empty.
  3. Make the SendFinalize use the buffered send system, so it's always sent after any buffered audio.

Please tell us about your environment

I'm using the latest dotnet on Linux.

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant