-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Log Replay for Change Data Feed #540
Merged
OussamaSaoudi-db
merged 60 commits into
delta-io:main
from
OussamaSaoudi-db:log_replay_2
Dec 6, 2024
Merged
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
e900d43
initial log replay
OussamaSaoudi-db a446d9a
Add basic mock table for testing
OussamaSaoudi-db 9b77cd2
Finish testing framework for commit actions
OussamaSaoudi-db 3a4c7cd
Fix deletion vectors
OussamaSaoudi-db 9345cfa
Add protocol test
OussamaSaoudi-db e2fe217
Make MockTable async
OussamaSaoudi-db d37ebc8
add schema check
OussamaSaoudi-db 4c1a616
Add config flag parsing
OussamaSaoudi-db 4bd3ab0
Add configuration check
OussamaSaoudi-db 748fd45
Change log replay to work with table changes scan
OussamaSaoudi-db 20230ec
add timestamp tests
OussamaSaoudi-db 6778d29
Use map_ok
OussamaSaoudi-db 25d1486
Address some pr comments
OussamaSaoudi-db d946deb
Integrate with table changes builder
OussamaSaoudi-db 095628a
Fix private visit_protocol, remove print
OussamaSaoudi-db 49fba0e
Change selection vector computation
OussamaSaoudi-db 2b260cc
Add comments for log replay
OussamaSaoudi-db 63121f0
more documentation
OussamaSaoudi-db e45a2ea
Add file-level doc
OussamaSaoudi-db 75dec49
Revert "Add file-level doc"
OussamaSaoudi-db 261b3f3
Add file level doc
OussamaSaoudi-db 67c88ae
Move common utils to utils::test_utils
OussamaSaoudi-db fc73579
Refactor to prepare for scan_file, remove unused annotation
OussamaSaoudi-db 0140a28
some documentation
OussamaSaoudi-db b45c75c
Change log replay api
OussamaSaoudi-db 8129e29
Address more comments
OussamaSaoudi-db f91e9a0
Move log replay tests to separate file
OussamaSaoudi-db 0a6030b
Move prepare phase into separate function
OussamaSaoudi-db 759d149
Add unused annotation
OussamaSaoudi-db d3d061b
More pr comments
OussamaSaoudi-db 4b6106f
Address more pr comments
OussamaSaoudi-db 5f644f0
remove type annotation
OussamaSaoudi-db fd38490
address pr comments
OussamaSaoudi-db 91b9f92
address more pr comments
OussamaSaoudi-db 3b2c3d3
add comments ,revert iterator change
OussamaSaoudi-db 3cf6955
Fix doc comment
OussamaSaoudi-db bf0d566
Share the data skipping filter
OussamaSaoudi-db e9423c4
PreparePhaseVisitor no longer has a new function
OussamaSaoudi-db 49921ef
fix clippy error
OussamaSaoudi-db 549cbdc
Add in more doc comments explaining data skipping filter is missing i…
OussamaSaoudi-db e05cedb
Add data change filtering
OussamaSaoudi-db 6a8eceb
add tests for failing table properties and protocol
OussamaSaoudi-db 5731e63
Remove ICT support
OussamaSaoudi-db 8628165
Fix naming, fix clippy
OussamaSaoudi-db f1b6ef9
Add link to issue for ICT support
OussamaSaoudi-db 28db41d
Add documentation for DVs
OussamaSaoudi-db 8b4aadb
appease clippy for row visitor
OussamaSaoudi-db 64e0a25
Add source for dvs
OussamaSaoudi-db 7fcc4dc
Address more pr comments
OussamaSaoudi-db 16a549c
Add comment to type widening
OussamaSaoudi-db e1d922b
Implement has_cdc_file optimization to skip add and remove checks if …
OussamaSaoudi-db 5533389
Shorten tests
OussamaSaoudi-db 562d65f
remove scan file that snuck in
OussamaSaoudi-db 3440577
Add doc comments, add an extra schema incompatibility test
OussamaSaoudi-db 5fd3d1c
Address pr comments
OussamaSaoudi-db d0eb811
Change tests to use higher level api
OussamaSaoudi-db 7108fd8
Update comments
OussamaSaoudi-db 1e4e09a
Add data skipping filter test
OussamaSaoudi-db 54382aa
Fix import issue
OussamaSaoudi-db c1d6103
Add unwrap so that test doesn't capture and check the wrong error
OussamaSaoudi-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another case where we may want to filter the schemas to show only their symmetric differences, to avoid drowning in details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case it wasn't obvious: This would be tracked as future work along with the other -- not for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, submitted this #564 to keep track.