From e4c68b991b4a3aa362bad5b66e8e3e856fec5ccd Mon Sep 17 00:00:00 2001
From: Zach Schuermann <zachary.zvs@gmail.com>
Date: Wed, 4 Dec 2024 11:18:11 -0800
Subject: [PATCH] add ict table property

---
 ffi/src/lib.rs                             |  3 ++-
 kernel/src/table_properties.rs             | 20 ++++++++++++++++++++
 kernel/src/table_properties/deserialize.rs |  9 +++++++++
 3 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/ffi/src/lib.rs b/ffi/src/lib.rs
index c3f0df935..5aa4aaab6 100644
--- a/ffi/src/lib.rs
+++ b/ffi/src/lib.rs
@@ -460,7 +460,8 @@ pub unsafe extern "C" fn set_builder_option(
 }
 
 /// Consume the builder and return a `default` engine. After calling, the passed pointer is _no
-/// longer valid_.
+/// longer valid_. Note that this _consumes_ and frees the builder, so there is no need to
+/// drop/free it afterwards.
 ///
 ///
 /// # Safety
diff --git a/kernel/src/table_properties.rs b/kernel/src/table_properties.rs
index 949bd5ac4..77f7bf6c7 100644
--- a/kernel/src/table_properties.rs
+++ b/kernel/src/table_properties.rs
@@ -137,6 +137,20 @@ pub struct TableProperties {
     /// whether to enable row tracking during writes.
     pub enable_row_tracking: Option<bool>,
 
+    /// Whether to enable [In-Commit Timestamps]. The in-commit timestamps writer feature strongly
+    /// associates a monotonically increasing timestamp with each commit by storing it in the
+    /// commit's metadata.
+    ///
+    /// [In-Commit Timestamps]: https://github.com/delta-io/delta/blob/master/PROTOCOL.md#in-commit-timestamps
+    pub enable_in_commit_timestamps: Option<bool>,
+
+    /// The version of the table at which in-commit timestamps were enabled.
+    pub in_commit_timestamp_enablement_version: Option<u64>,
+
+    /// The timestamp of the table at which in-commit timestamps were enabled. This must be the same
+    /// as the inCommitTimestamp of the commit when this feature was enabled.
+    pub in_commit_timestamp_enablement_timestamp: Option<i64>,
+
     /// any unrecognized properties are passed through and ignored by the parser
     pub unknown_properties: HashMap<String, String>,
 }
@@ -268,6 +282,9 @@ mod tests {
             ("delta.tuneFileSizesForRewrites", "true"),
             ("delta.checkpointPolicy", "v2"),
             ("delta.enableRowTracking", "true"),
+            ("delta.enableInCommitTimestamps", "true"),
+            ("delta.inCommitTimestampEnablementVersion", "15"),
+            ("delta.inCommitTimestampEnablementTimestamp", "1612345678"),
         ];
         let actual = TableProperties::from(properties.into_iter());
         let expected = TableProperties {
@@ -293,6 +310,9 @@ mod tests {
             tune_file_sizes_for_rewrites: Some(true),
             checkpoint_policy: Some(CheckpointPolicy::V2),
             enable_row_tracking: Some(true),
+            enable_in_commit_timestamps: Some(true),
+            in_commit_timestamp_enablement_version: Some(15),
+            in_commit_timestamp_enablement_timestamp: Some(1_612_345_678),
             unknown_properties: HashMap::new(),
         };
         assert_eq!(actual, expected);
diff --git a/kernel/src/table_properties/deserialize.rs b/kernel/src/table_properties/deserialize.rs
index c9da1495b..9f34dc284 100644
--- a/kernel/src/table_properties/deserialize.rs
+++ b/kernel/src/table_properties/deserialize.rs
@@ -76,6 +76,15 @@ fn try_parse(props: &mut TableProperties, k: &str, v: &str) -> Option<()> {
         }
         "delta.checkpointPolicy" => props.checkpoint_policy = CheckpointPolicy::try_from(v).ok(),
         "delta.enableRowTracking" => props.enable_row_tracking = Some(parse_bool(v)?),
+        "delta.enableInCommitTimestamps" => {
+            props.enable_in_commit_timestamps = Some(parse_bool(v)?)
+        }
+        "delta.inCommitTimestampEnablementVersion" => {
+            props.in_commit_timestamp_enablement_version = Some(parse_int(v)?)
+        }
+        "delta.inCommitTimestampEnablementTimestamp" => {
+            props.in_commit_timestamp_enablement_timestamp = Some(parse_int(v)?)
+        }
         _ => return None,
     }
     Some(())