Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet generator doesn't handle cycles #1

Open
L3nn0x opened this issue Dec 7, 2018 · 4 comments
Open

Packet generator doesn't handle cycles #1

L3nn0x opened this issue Dec 7, 2018 · 4 comments

Comments

@L3nn0x
Copy link
Collaborator

L3nn0x commented Dec 7, 2018

The generator detects cycles, but doesn't do anything about it.

@RavenX8
Copy link
Contributor

RavenX8 commented Feb 11, 2019

what's a cycle?

@L3nn0x
Copy link
Collaborator Author

L3nn0x commented Feb 12, 2019

the xml is a directed graph so technically we can have cycles (a type that uses another type, which itself uses the first type). It'd require a forward declaration of the second type probably, and use a unique_ptr<> instead of a variable on the stack to break the dependency cycle.

@RavenX8
Copy link
Contributor

RavenX8 commented Feb 12, 2019

oh cool. that would be nice.

@L3nn0x
Copy link
Collaborator Author

L3nn0x commented Apr 3, 2019

Not sure if it'd be useful tho, so I won't change it until we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants