We just switched to the new Proto library build rules in the [instrumentation-proto](https://github.com/google/instrumentation-proto) repository, by following the instructions at https://bazel.build/blog/index.html#protocol-buffers-in-bazel. Here is the pull request: https://github.com/google/instrumentation-proto/pull/26 #918
Labels
info-needed
Issue requires more information from poster
We just switched to the new Proto library build rules in the instrumentation-proto repository, by following the instructions at https://bazel.build/blog/index.html#protocol-buffers-in-bazel. Here is the pull request: census-instrumentation/opencensus-proto#26
Then we updated a git submodule to bring the changes into instrumentation-java, as in this commit: sebright/opencensus-java@95a6691
We were building
instrumentation-java
with--javacopt=-Werror --javacopt=-Xlint:all
in CI. After the change, we started getting many errors that seemed to come from thecom_google_protobuf_java
http_archive
target in our WORKSPACE file. Here is part of the list of errors from the failed Travis build:The full command was:
(We were already suppressing some other warnings.)
The full log is at https://travis-ci.org/sebright/instrumentation-java/jobs/212241166 .
Bazel version:
I expected bazel to not fail the build in this case, for two reasons:
com_google_protobuf_java
is only a dependency of the project. I think there should be a way to only fail if warnings come from the targets in theBUILD
file. (Is there already an option that does that?)java_proto_library
shouldn't cause errors, because it is a built-in build rule./cc @bogdandrutu
Originally posted by @sebright in bazelbuild/bazel#2699 s-out/
antlr3/
contrib/
Documentation/
e2e-tests/
java/
javatests/
lib/
modules/
plugins/
polygerrit-ui/
prolog/
prologtests/
proto/
resources/
tools/
webapp/
polymer-bridges
.bazelignore
.bazelproject
.bazelrc
.bazelversion
.editorconfig
.git-blame-ignore-revs
.gitignore
.gitmodules
.gitreview
.mailmap
.pydevproject
.zuul.yaml
BUILD
COPYING
INSTALL
Jenkinsfile
package.json
README.md
SUBMITTING_PATCHES
version.bzl
web-dev-server.config.mjs
WORKSPACE
yarn.lock
The text was updated successfully, but these errors were encountered: