Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Endpoint Factory to pure FastAPI application #5

Open
vincentsarago opened this issue Apr 27, 2022 · 1 comment
Open

Switch from Endpoint Factory to pure FastAPI application #5

vincentsarago opened this issue Apr 27, 2022 · 1 comment

Comments

@vincentsarago
Copy link
Member

If we want to follow the Core specification (Part 1) we need to conform the landing page (/) and it HAS TO have the service-doc or service-desc links. Those links are defined at the FastAPI application level and not at the router level (which we create with the endpoint factory).

IMO for this project it will be ok to move away from the endpoint factory to a app factory (e.g stac-fastapi)

@vincentsarago
Copy link
Member Author

After talking with @bitner, the application factory is not a model we need/want because we want to keep the possibility to import routes to pre-built application.

The main problem of the EndpointFactory we have right now is how the landing page links are created (we need to have access to the service-doc and service-desc path that are defined at FastAPI application level and not at Router level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant