Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of tool 'naabu' is not working in the lastest version #98

Open
angrox opened this issue Apr 27, 2021 · 4 comments
Open

Installation of tool 'naabu' is not working in the lastest version #98

angrox opened this issue Apr 27, 2021 · 4 comments

Comments

@angrox
Copy link
Contributor

angrox commented Apr 27, 2021

The installation of naabu fails in the latest version 2.0.3:

binenv install naabu 2021-04-27T06:44:38Z WRN version for "naabu" not specified; using "2.0.3" 2021-04-27T06:44:38Z ERR unable to install "naabu" (2.0.3) error="unable to download binary at https://github.com/projectdiscovery/naabu/releases/download/v2.0.3/naabu_2.0.3_linux_amd64.tar.gz: 404 Not Found"

Reason: Project switched the filename deliminator from underscore to dash

Normally I would just fix it and open a PR but this only affects the latest version so changing it would break all older versions.

Any ideas of how to fix it?

@angrox angrox changed the title Installation of tool 'naabo' is not working in the lastest version Installation of tool 'naabu' is not working in the lastest version Apr 27, 2021
@leucos
Copy link
Contributor

leucos commented Apr 27, 2021

Thanks for the report @angrox . Interesting use case.

Well, for now we do not have many solutions:

  1. break backward compatibility
  2. add another entry in the distributions file (with a different name, e.g. nabu2)

Could be interesting in the future to have multiple URLs for fetch releases.

@angrox
Copy link
Contributor Author

angrox commented Apr 28, 2021

I also thought of multiple URLs to check against but was unsure if such a PR would be accepted.

I am not happy with breaking backward compatibility neither with a second entry for the same tool. :-/

@leucos
Copy link
Contributor

leucos commented Apr 28, 2021

I think this is a good idea.
May be we can use :

fetch:
      urls:

so we preserve backward compatibility.

We'll keep fetch.url for a while until we bump major version.

What do you think ?

@xx4h
Copy link
Contributor

xx4h commented Mar 23, 2024

I worked on this, see #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants