Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HandleItemsCrafting #711

Open
ItsZodiaX opened this issue Dec 18, 2022 · 2 comments
Open

Implement HandleItemsCrafting #711

ItsZodiaX opened this issue Dec 18, 2022 · 2 comments
Labels
improvement Improvement of an existing part of the codebase

Comments

@ItsZodiaX
Copy link
Contributor

new HandleItemsCrafting on the player handler.

There is no way to stop players from crafting items. Just need a handle to cancel that.
@JustTalDevelops JustTalDevelops added the improvement Improvement of an existing part of the codebase label Dec 19, 2022
@JustTalDevelops
Copy link
Member

Since all crafting related actions are handled within the session itself - how do we want to handle this? One option could be to move the actual crafting processing related code to *player.Player and call the handler from there.

@JustTalDevelops
Copy link
Member

Keep in mind that this is also probably desirable within other crafting related blocks, such as stonecutters or looms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement of an existing part of the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustTalDevelops @ItsZodiaX