Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Ontology managers #124

Open
LckyLke opened this issue Dec 12, 2024 · 3 comments
Open

Deprecating Ontology managers #124

LckyLke opened this issue Dec 12, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@LckyLke
Copy link
Collaborator

LckyLke commented Dec 12, 2024

As talk about in our meeting on Monday, we do not use ontology managers to apply changes to ontologies at the moment.
In their current implementation they don't really serve any obvious purpose.

In the OWL API library the ontology managers are used to centralize management, i.e. creation, loading, saving, and modification of ontologies. We could either do it this way or apply changes directly on the Ontologies, which would eliminate the need for ontology managers.

@LckyLke LckyLke added the enhancement New feature or request label Dec 12, 2024
@LckyLke
Copy link
Collaborator Author

LckyLke commented Dec 12, 2024

"All ontology changes are applied through an ontology manager. This means that it is possible to apply a list of ontology changes, which make multiple changes to multiple ontologies, as a single unit. This works well for applications such as ontology editors, where an edit operation such as entity name change (entity IRI change) can involve the addition and removal of multiple axioms from multiple ontologies..." from here.

If we also want to support something like this, managers might be useful

@Demirrr
Copy link
Member

Demirrr commented Dec 12, 2024

@alkidbaci agreed ?

@alkidbaci
Copy link
Collaborator

alkidbaci commented Dec 16, 2024

Yes I think we can depreciate the ontology manager because as Luke said, they dont really serve any purpose now. Should keep in mind during refactoring that "Sync" classes still need to use owlapi's OntologyManager.

Also OWLImportsDeclaration and AddImport should be depricated along with the manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants