Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unregister event listeners when component is unmounted #26

Open
jawadst opened this issue Nov 16, 2020 · 1 comment
Open

Unregister event listeners when component is unmounted #26

jawadst opened this issue Nov 16, 2020 · 1 comment

Comments

@jawadst
Copy link
Contributor

jawadst commented Nov 16, 2020

When the DidomiSDK component is unmounted from the DOM, ensure that all the registered event listeners get de-registered to avoid memory leaks.
@jawadst jawadst mentioned this issue Nov 16, 2020
Merged
@laarakus
Copy link

can we have some feedback on this issue, because it lowers best practices score in lighthouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jawadst @laarakus