Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App does not work on leap days #109

Open
matteolimberto-da opened this issue Feb 29, 2024 · 0 comments
Open

App does not work on leap days #109

matteolimberto-da opened this issue Feb 29, 2024 · 0 comments

Comments

@matteolimberto-da
Copy link
Contributor

A small finding in Daml Finance App. Today (29th Feb 2024) when I bring up with daml start , an error came up

Exception in thread "main" com.daml.lf.engine.script.Runner$InterpretationError: Error: Unhandled Daml exception: DA.Exception.GeneralError:GeneralError@86828b98{ message = "Day 29 falls outside of valid day range (1 .. 28) for Feb 2021." }

I found that there are several scripts using (ty, tm, td) = toGregorian today , and in some places a date is referred to date 2021 tm td which causes this error.
Don’t think we need immediate fix as the next time it comes up is 29/2/2028.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant