Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color to Language model #2390

Closed
MizukiTemma opened this issue Aug 7, 2023 · 4 comments · Fixed by #2715
Closed

Add color to Language model #2390

MizukiTemma opened this issue Aug 7, 2023 · 4 comments · Fixed by #2715
Assignees
@lunars97
Labels
effort: high Big change, which requires >12h feature New feature or request good first issue Good for newcomers prio: medium Should be scheduled in the forseeable future.
Milestone
24Q3

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Aug 7, 2023 •
edited
Loading

Motivation

Page access statistics will bring higher understandability if each language has a certain fixed color regardless of which region it is.
Currently languages receive a color in the order, which means:

If
Color order: Red, Yellow, Green, White
Region1 has: German, English, Arabic
Region2 has: German, Arabic, Chinese

Then
Region1: German-Red, English-Yellow, Arabic-Green
Region2: German-Red, Arabic-Yellow, Chinese-Green

What we want is, for example:
German-Red, English-Yellow, Arabic-Green, Chinese-White in all regions.

Proposed Solution

Add a color field to the language model, like color in POI category

Alternatives

User Story

Additional Context

This must be implemented before #1097

Design Requirements

Which colors should be in the choice, will come from @hauf-toni
@MizukiTemma MizukiTemma added feature New feature or request ui-ux Issues that requires an UI/UX perspective. labels Aug 7, 2023
@MizukiTemma MizukiTemma added this to the 23Q4 milestone Aug 7, 2023
@dkehne
Copy link

dkehne commented Sep 11, 2023

Good idea, i will move it to Q1/2024 because it can wait some more weeks.

@dkehne dkehne modified the milestones: 23Q4, 24Q1 Sep 11, 2023
@hauf-toni
Copy link

once you are ready to implement this, you can find my color suggestion in this file 🔴🔵🟣

@timobrembeck timobrembeck changed the title Add color to language Add color to Language model Oct 25, 2023
@timobrembeck timobrembeck added good first issue Good for newcomers and removed ui-ux Issues that requires an UI/UX perspective. labels Oct 25, 2023
@dkehne dkehne modified the milestones: 24Q1, 24Q3 Dec 11, 2023
@dkehne
Copy link

dkehne commented Dec 11, 2023

moved to 24Q3 because page based statistics moved as well.

@lunars97
Copy link
Contributor

can I try to work on this ticket? Would that be fine?

@lunars97 lunars97 self-assigned this Mar 26, 2024
@lunars97 lunars97 mentioned this issue Mar 28, 2024
Merged
@JoeyStk JoeyStk added effort: high Big change, which requires >12h prio: medium Should be scheduled in the forseeable future. labels May 27, 2024
@MizukiTemma MizukiTemma mentioned this issue Jun 17, 2024
Merged
@MizukiTemma MizukiTemma mentioned this issue Jul 24, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunars97 lunars97

Labels
effort: high Big change, which requires >12h feature New feature or request good first issue Good for newcomers prio: medium Should be scheduled in the forseeable future.
Projects
None yet
Milestone
24Q3
Development

Successfully merging a pull request may close this issue.

Add color to language model digitalfabrik/integreat-cms
6 participants
@dkehne @timobrembeck @JoeyStk @lunars97 @MizukiTemma @hauf-toni