Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-11-07] Create form for contacts #2953

Closed
Tracked by #2955
MizukiTemma opened this issue Aug 1, 2024 · 5 comments · Fixed by #3034
Closed
Tracked by #2955

[2024-11-07] Create form for contacts #2953

MizukiTemma opened this issue Aug 1, 2024 · 5 comments · Fixed by #3034
Assignees
Labels
deadline Needs to be fixed in the given time effort: medium Should be doable in <12h feature New feature or request prio: high Needs to be resolved ASAP.
Milestone

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Aug 1, 2024

Motivation

We are introducing a new feature "contact information". A form is needed for it.

Proposed Solution

Implement a form to create a new contact and to edit an existing one.

❓ Make it sure at least one of E-mail address, telephone number or website is given.
💡 Reuse venue_box.html for the step of selecting/creating a POI.
💡 Reuse _related_contents_table.html to show where the contact is embedded.

Alternatives

None. We do it.

User Story

Additional Context

Wait for #2952

Design Requirements

See the design here
⚠️ There are two versions in the link above. New Version 30.07 is the one we have to implement.

@MizukiTemma MizukiTemma added the feature New feature or request label Aug 1, 2024
@MizukiTemma MizukiTemma added blocked Blocked by external dependency effort: medium Should be doable in <12h labels Aug 1, 2024
@MizukiTemma MizukiTemma changed the title Create a list for contacts Create form for contacts Aug 1, 2024
@MizukiTemma MizukiTemma added this to the 24Q3 milestone Aug 7, 2024
@MizukiTemma MizukiTemma added the prio: high Needs to be resolved ASAP. label Aug 7, 2024
@JoeyStk JoeyStk changed the title Create form for contacts [7.11.24] Create form for contacts Aug 16, 2024
@JoeyStk JoeyStk added the deadline Needs to be fixed in the given time label Aug 16, 2024
@MizukiTemma MizukiTemma self-assigned this Aug 20, 2024
@MizukiTemma
Copy link
Member Author

The cancel (Abbrechen) button will be implemented in #2930. It is not consistent with other contents and may be confusing for users if the cancel button is only available in the contact form.

@MizukiTemma
Copy link
Member Author

blocked by #3015

@MizukiTemma
Copy link
Member Author

MizukiTemma commented Aug 28, 2024

The design suggests to mark the fields "title" and "name" with * to make it clear that they are mandatory, but mandatory fields of other forms are not marked at all. Should we probably introduce the * systemwide at once, to avoid inconsistency and confusion? #3028

@MizukiTemma MizukiTemma removed the blocked Blocked by external dependency label Sep 11, 2024
@MizukiTemma
Copy link
Member Author

MizukiTemma commented Sep 19, 2024

TBD: removing E-mail, phone number and website from POI.

We have those three fields not only in POIs but also in contacts. If those fields are managed only in contacts, we can avoid redundancy, maintenance like #3033 and check boxes in #3034 .

@david-venhoff Feel free to add commnets 😸
@PeterNerlich You're invited to the discussion too 😸

@MizukiTemma
Copy link
Member Author

MizukiTemma commented Oct 1, 2024

TBD: removing E-mail, phone number and website from POI.

We have those three fields not only in POIs but also in contacts. If those fields are managed only in contacts, we can avoid redundancy, maintenance like #3033 and check boxes in #3034 .

@david-venhoff Feel free to add commnets 😸 @PeterNerlich You're invited to the discussion too 😸

This idea was confirmed and will be implemented. See #3086

There are some other changes needed while discussion:

  1. Make title and name not mandatory
  2. One of the following fields must be filled: title, name, email, phone number, website
  3. Only one contact is allowed to have a blank title per POI.

TBD: renaming title

@osmers osmers modified the milestones: 24Q3, 24Q4 Oct 2, 2024
@JoeyStk JoeyStk changed the title [7.11.24] Create form for contacts [2024-11-07] Create form for contacts Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time effort: medium Should be doable in <12h feature New feature or request prio: high Needs to be resolved ASAP.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants