Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use 32 bit integers #26

Open
dirkschumacher opened this issue Jan 16, 2021 · 0 comments
Open

Don't use 32 bit integers #26

dirkschumacher opened this issue Jan 16, 2021 · 0 comments

Comments

@dirkschumacher
Copy link
Owner

Currently all integers are converted to R's 32 bit integers. I think we should use doubles here with maybe a custom vctrs class to avoid overflow.

Bonus: think about using Arbitrary precision library such as rmpf if the integer is too large for doubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant