Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is more than one Author, the last one is printed in the citation #73

Open
alxp opened this issue Jun 27, 2024 · 1 comment
Open

Comments

@alxp
Copy link

alxp commented Jun 27, 2024

Steps to reproduce

Set up a field with a Typed Relation for the Author citation.

  • In our case we have a Contributor paragraph type that holds the Contributor Name as a typed relation.

Create a piece of content that includes more than one Contributor field item.

View the citation in the block for the content.

Expected behaviour

[edit] The citaion should show all authors in the order they are arranged on the entity.

Observed behaviour

The last item in the set of Author fields is the one displayed.

I can provide more details if that would be helpful.

@alxp
Copy link
Author

alxp commented Jun 28, 2024

Looking into this further, I see it's happening when you have a field structure like this

Title
Contributor Paragraph 1

  • Contributor Name typed relation field
  • Contributor Paragraph 2
  • Contributor Name typed relation field

Where the Field Item List normalizer is overwriting the values as it loops through the fields.

PR forthcoming.

alxp added a commit to Born-Digital-US/islandora_citations that referenced this issue Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant