Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse image slideshow #44

Open
yous opened this issue Oct 2, 2014 · 12 comments
Open

Parse image slideshow #44

yous opened this issue Oct 2, 2014 · 12 comments

Comments

@yous
Copy link
Collaborator

yous commented Oct 2, 2014

http://www.reuters.com/article/2014/10/02/us-hongkong-china-idUSKCN0HN03Q20141002

@disjukr
Copy link
Owner

disjukr commented Oct 2, 2014

what do you think about using slick?

@disjukr
Copy link
Owner

disjukr commented Oct 2, 2014

oh i forgot we can't use js library...

@yous
Copy link
Collaborator Author

yous commented Oct 2, 2014

Will including external scripts with script tag work with user script?

@disjukr
Copy link
Owner

disjukr commented Oct 2, 2014

i have no idea

@yous
Copy link
Collaborator Author

yous commented Oct 2, 2014

Even if we can include external scripts, slick is dependent on jQuery 1.7. So we should include jQuery to use slick which might not be the way we want to do.

@yous
Copy link
Collaborator Author

yous commented Oct 6, 2014

Also there is an slideshow on 국민일보: http://news.kmib.co.kr/article/view.asp?arcid=0008738738&code=61111111&sid1=pol&sid2=0001

@yous yous changed the title Parse the header slideshow on 로이터 Parse image slideshow Oct 6, 2014
@yous
Copy link
Collaborator Author

yous commented Oct 18, 2014

#55 parses the header slideshow on 로이터.

@yous
Copy link
Collaborator Author

yous commented Oct 18, 2014

It'll be nice if we transport the code of #55 to jews like:

jews.slides: slide[]
slide = {
    img: string // src
    caption: string
}

@disjukr
Copy link
Owner

disjukr commented Oct 18, 2014

agree

@xnuk
Copy link
Contributor

xnuk commented Nov 11, 2014

var slides = [];
[].forEach.call(document.querySelectorAll('#gisaimage>.pic #picLst'), function (v) {
    var b = {};
    b.img = v.getElementsByTagName('img')[0].src;
    b.caption = v.getElementsByClassName('captn')[0].innerText;
    slides.push(b);
});

국민일보 seems like a simple work because it doesn't need to use XHR. I'll add a slideshow for 국민일보 like #55 tomorrow night if nobody will make it.

@disjukr
Copy link
Owner

disjukr commented Dec 10, 2014

이거 일반화하려면 일단 기존에 만들어진 슬라이드 구현들을 좀 모을 필요가 있겠네요.
#74 (comment) 에서 비동기 파싱도 커버하게 바뀌었으니 페이지 재구성 끝난 다음에 업데이트하던 녀석들도 문제 없을 것 같아요.
@xnuk 혹시 그동안 구현하셨던 이미지 슬라이드 사이트들 목록 정리해주실 수 있나요?

@xnuk
Copy link
Contributor

xnuk commented Dec 11, 2014

@disjukr 그냥 국민일보 #72 하고 로이터 #55 밖에 안 했어요. 로이터는 JSON을 불러와야 해서 xhr 써서 이런 이상야릇한 수법을 썼습니다만 이제 비동기로 뜯어 고쳐야겠네요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants