-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse image slideshow #44
Comments
what do you think about using slick? |
oh i forgot we can't use js library... |
Will including external scripts with |
i have no idea |
Even if we can include external scripts, slick is dependent on jQuery 1.7. So we should include jQuery to use slick which might not be the way we want to do. |
Also there is an slideshow on 국민일보: http://news.kmib.co.kr/article/view.asp?arcid=0008738738&code=61111111&sid1=pol&sid2=0001 |
#55 parses the header slideshow on 로이터. |
It'll be nice if we transport the code of #55 to jews like:
|
agree |
var slides = [];
[].forEach.call(document.querySelectorAll('#gisaimage>.pic #picLst'), function (v) {
var b = {};
b.img = v.getElementsByTagName('img')[0].src;
b.caption = v.getElementsByClassName('captn')[0].innerText;
slides.push(b);
}); 국민일보 seems like a simple work because it doesn't need to use XHR. I'll add a slideshow for 국민일보 like #55 tomorrow night if nobody will make it. |
이거 일반화하려면 일단 기존에 만들어진 슬라이드 구현들을 좀 모을 필요가 있겠네요. |
@disjukr 그냥 국민일보 #72 하고 로이터 #55 밖에 안 했어요. 로이터는 JSON을 불러와야 해서 xhr 써서 이런 이상야릇한 수법을 썼습니다만 이제 비동기로 뜯어 고쳐야겠네요. |
http://www.reuters.com/article/2014/10/02/us-hongkong-china-idUSKCN0HN03Q20141002
The text was updated successfully, but these errors were encountered: