Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example apps in docs #346

Open
adamchainz opened this issue Sep 30, 2022 · 4 comments
Open

Example apps in docs #346

adamchainz opened this issue Sep 30, 2022 · 4 comments

Comments

@adamchainz
Copy link
Member

The spec currently defines a lot of details without any example apps (except in the lifespan section). It would be good to include basic examples, perhaps function and class versions for both full apps and middleware.
@Kludex
Copy link
Contributor

Kludex commented Dec 27, 2022

Do we want one for each: HTTP, WebSockets, and extensions?

If I receive the Andrew's ack here, I can work on a PR. 👍

@andrewgodwin
Copy link
Member

If you can somehow make them clean and simple, sure!

@Kludex
Copy link
Contributor

Kludex commented Dec 28, 2022

Is this clean and simple: #366 ?

@Kludex Kludex mentioned this issue Dec 28, 2022
Closed
@andrewgodwin
Copy link
Member

It is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewgodwin @adamchainz @Kludex