Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected profiles: clicking "add profile" on empty should show error message #149

Open
smirolo opened this issue Sep 3, 2019 · 4 comments
Milestone

Comments

@smirolo
Copy link
Contributor

smirolo commented Sep 3, 2019

The API calls returns a 400 when clicking "add profile" without entering any input in the text box but no UI elements is showing what is happening.
1/ Mark the input box with a red border.
2/ add a "Please enter the name of a profile you are looking for." message under the input box.

@knivets
Copy link
Contributor

knivets commented Oct 21, 2019

This problem can be solved by just adding required attribute. Let me know if you still want me to code the custom error logic.

@smirolo
Copy link
Contributor Author

smirolo commented Oct 23, 2019

Will adding required trigger some feedback to the user?

@knivets
Copy link
Contributor

knivets commented Oct 23, 2019

Yes, the native browser error message

@smirolo
Copy link
Contributor Author

smirolo commented Oct 24, 2019

OK. Make sure the required is added as part of the PR for #77.

@smirolo smirolo added this to the 2019-10-26 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants