Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: why must port 80 be used? (why not SSL) #26

Open
siebertm opened this issue Oct 17, 2017 · 2 comments
Open

Question: why must port 80 be used? (why not SSL) #26

siebertm opened this issue Oct 17, 2017 · 2 comments

Comments

@siebertm
Copy link

Additionally, glghproxy MUST operate on tcp/80.

I understand the what, but this means that we have unencrypted traffic going around, which we obviously don't like.

I dont understand the why though, can you elaborate a bit more on that? And - more importantly - what would be needed to allow at least default SSL port to work, so we can use TLS?

@cpfeiffer
Copy link
Contributor

It needs some patches to enable SSL verification, but it works just fine then. You can find the changes in https://github.com/GEBIT/gitlab-github-proxy/tree/GEBIT, if you are interested.

@dka23
Copy link
Owner

dka23 commented Oct 18, 2017

I'm happy to accept any merge requests to change this. When I first developed this thing, adding SSL just seemed to be an additional overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants