-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to poetry #314
Comments
- Remove setup.py - Switch to pyproject.toml - Update GitHub actions to use poetry - Clean up code a bit according to feedback from flake8 - Update release guide
- Use ruff - Address linter issues in json.py
Aside from personal preference, do you see any advantages of using In my experience, |
I prefer a declarative approach to the build like it is provided by I have briefly tried using |
Yes, locking down the dependency graph is probably the biggest advantage of poetry. Personally, I think that the installation of However, this shouldn't block you if you think it is a good decision to switch to poetry. We will need to pay special attention to adjusting the Github actions to Poetry as they are not tested automatically (especially the release build). |
So far, all I had to do was |
On the link that I posted above, it says:
So you will need to use a second virtual environment to manage poetry itself. |
Meh... 👎 😐 Are there sensible alternatives to setuptools and poetry that could be considered? Or is there a way to have setuptools lock down the dependency graph? |
There is a library called Again, I am not sure if this is actually required for a small project with rather limited dependencies. |
- Use ruff - Address linter issues in json.py
Describe the refactoring action
Switch to poetry and pyproject.toml.
Expected benefit
Align with pycaprio and I kind of like the declarative nature of pyproject.toml vs the setup.py.
The text was updated successfully, but these errors were encountered: