Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible pipeline does not work ? #8809

Open
belforte opened this issue Nov 22, 2024 · 8 comments
Open

flexible pipeline does not work ? #8809

belforte opened this issue Nov 22, 2024 · 8 comments
Assignees

Comments

@belforte
Copy link
Member

belforte commented Nov 22, 2024

I tried this, after tagging a local clone of current master

TAG=v3.241122.1
git tag $TAG
git push gitlab $TAG -o ci.variable="SUBMIT_STATUS_TRACKING=t"

pipeline: https://gitlab.cern.ch/crab3/CRABServer/-/pipelines/8572192

and this

TAG=v3.241122.1
git tag $TAG
git push gitlab $TAG -o ci.variable="SUBMIT_STATUS_TRACKING=t" -o ci.variable="SKIP_BUILD=t" -o ci.variable="SKIP_DEPLOY=t"

pipeline: https://gitlab.cern.ch/crab3/CRABServer/-/pipelines/8572202

but in both cases the standard pipeline was run with un-desired build-deploy steps and the status tracking tasks were not submitted, nor looked for.

Can you please document how the new options work ? Best with new files in cicd/trigger-ci/

@aspiringmind-code
Copy link
Contributor

@belforte You need to explicitly use true and not t.

git push gitlab $TAG -o ci.variable="SUBMIT_STATUS_TRACKING=true" -o ci.variable="SKIP_BUILD=true" -o ci.variable="SKIP_DEPLOY=true"

I used this to create the pipeline https://gitlab.cern.ch/crab3/CRABServer/-/pipelines/8584828
Please let me know if that resolves your issue. I will add it to cicd/trigger-ci Thanks!

@belforte
Copy link
Member Author

I see. Will try when done with current emergency
I was mislead by the use of =t in current scripts in cicd/trigget-ci
Hopefully you can find a way to have a consistent interface

@aspiringmind-code
Copy link
Contributor

The ci-trigger scripts have been updated and explicit true is used everywhere now. See #8812

@belforte
Copy link
Member Author

I have not tested status tracking yet, but I noticed that even if I don't, the jobs are still submitted https://gitlab.cern.ch/crab3/CRABServer/-/jobs/46494960

I am still confused

@aspiringmind-code
Copy link
Contributor

@belforte By default, the SUBMIT_STATUS_TRACKING is true. So if you don't specify anything, they will be submitted. You can turn it off by specifying it as false.

@belforte
Copy link
Member Author

isn't it odd that by default sunmission is true but checking is false ? if there's no check, why submit ?

@aspiringmind-code
Copy link
Contributor

Hmm...makes sense. I can turn the default to false.

@belforte
Copy link
Member Author

IMHO there should be only one flag: to execute or not a given test, which controls both submission and checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants