Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile #74

Open
darxkies opened this issue Jan 31, 2017 · 2 comments
Open

Does not compile #74

darxkies opened this issue Jan 31, 2017 · 2 comments

Comments

@darxkies
Copy link

Hi

I am getting the following error.

github.com/docker/go-plugins-helpers/sdk/unix_listener.go:20: cannot use gid (type int) as type string in argument to sockets.NewUnixSocket

That is due to the fact that I stick to the last tagged version of docker/go-connections (v0.2.1).

go-plugins-helpers seems to use the master version of docker/go-connections.

Wouldn't it be better to also use only tagged versions of go-connections?

Thank you.

@dave-tucker
Copy link
Contributor

@darxkies thanks for the report.
IIRC, the Golang best practice was for libraries not to specify versions of their dependencies but instead for that to be the responsibility of the consumers. I don't think this has changed, and I think this remains a pretty sensible default but I'm open to suggestions.
As a workaround, bumping your version of go-connection should fix the issue.

@darxkies
Copy link
Author

darxkies commented Feb 1, 2017

You are right. I will hack the appropriate commit id into the glide config to avoid the error.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants