Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate sorce epoch timestamps #9

Open
errordeveloper opened this issue Aug 29, 2023 · 2 comments
Open

investigate sorce epoch timestamps #9

errordeveloper opened this issue Aug 29, 2023 · 2 comments

Comments

@errordeveloper
Copy link
Contributor

errordeveloper commented Aug 29, 2023

Currently, tape picks the most recent modtime from files in manifest dir and uses that to set source epoch.

There is this TODO note:

https://github.com/docker/labs-brown-tape/blob/279e45a0f87718866ac7cc99916efde14f7b44ca/manifest/loader/loader.go#L71-L77

@errordeveloper
Copy link
Contributor Author

@stefanprodan you also mentioned that you've seen various CI systems not handling modtimes well, I would have thought that this should be down to whatever git writes out on checkout. I've not checked what Git does exactly yet, but I am assuming it picks up the commit timestamp? Were you speaking of some crazy CI hack you've seen?

@stefanprodan
Copy link

What I've seen are CI jobs who do modify files due to various reasons (e.g. writing some file in a dir then delete it), that's why I think using the Git metadata and set the created timestamp to the HEAD commit TS is the best way to achieve reproducible builds, this is also the recommendation made by https://reproducible-builds.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants